drop docker from makefile and README #611
Conversation
MatousJobanek
requested review from
xcoulon,
alexeykazakov,
rajivnathan,
ranakan19 and
mfrancisc
as code owners
| .PHONY: set-os-registry | ||
| ## Sets TARGET_REGISTRY:=$(shell oc get images.config.openshift.io/cluster -o jsonpath={.status.externalRegistryHostnames[0]}) | ||
| set-os-registry: | ||
| $(eval TARGET_REGISTRY:=$(shell oc get images.config.openshift.io/cluster -o jsonpath={.status.externalRegistryHostnames[0]})) |
There was a problem hiding this comment.
We could maybe start using the internal OpenShift registry to simplify the dev setup/environment.
There was a problem hiding this comment.
I can take a look at it when I'll work on the CI/CD changes that will be needed for moving repos to kubesaw GH org, and for introducing standard semver releases.
|
|
/retest |
|
infra issue /retest |
|
/lgtm |
|
infra issue /retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexeykazakov, MatousJobanek, rajivnathan, xcoulon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #611 +/- ##
=======================================
Coverage 81.59% 81.59%
=======================================
Files 29 29
Lines 3292 3292
=======================================
Hits 2686 2686
Misses 457 457
Partials 149 149 |
openshift-merge-bot
bot
merged commit 22cd84e
into
codeready-toolchain:master
docker.mktopodman.mk(contains only podman targets now)